Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK 1.15 #1182

Merged
merged 4 commits into from
Jun 27, 2024
Merged

SDK 1.15 #1182

merged 4 commits into from
Jun 27, 2024

Conversation

Erol444
Copy link
Member

@Erol444 Erol444 commented Jun 25, 2024 •
edited
Loading

Added ToF configuration function, support ToF depth from pointcloud, pin numpy below 2.0, depthai-sdk to 1.15

@Erol444 Erol444 requested a review from jakaskerl June 25, 2024 18:49
@Erol444 Erol444 changed the title Added ToF configuration function, support ToF depth from pointcloud, … SDK 1.15 Jun 25, 2024
jakaskerl
jakaskerl reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@jakaskerl jakaskerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stock pointcloud example is not working, because of the changed parameter name.

depthai_sdk/src/depthai_sdk/components/pointcloud_component.py Outdated Show resolved Hide resolved
@jakaskerl
Copy link
Contributor

I see we have 2 requirements files, one in base depthai dir and one in sdk. The first one needs numpy version lock. Would it make sense to put them into a single file and have install_requirements.py as we have in depthai-python?

@Erol444 Erol444 requested a review from jakaskerl June 27, 2024 11:22
jakaskerl
jakaskerl approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jakaskerl jakaskerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Erol444 Erol444 merged commit d988376 into main Jun 27, 2024
4 checks passed
@Erol444 Erol444 deleted the tof_and_pointcloud branch June 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakaskerl jakaskerl jakaskerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erol444 @jakaskerl