Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out override of -mdmp parameter #1098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CenekAlbl
Copy link
Contributor

Previously forced fisheye cameras to always detect all markers during calibration. Not needed.

… to always detect all markers during calibration. Not needed.



def calibrate(self):
print("Starting image processing")
stereo_calib = calibUtils.StereoCalibration()
stereo_calib.traceLevel = self.args.traceLevel
stereo_calib = calibUtils.StereoCalibration(self.args.traceLevel, self.args.outputScaleFactor, self.args.disableCamera)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arguments are deployed in https://github.com/luxonis/depthai-calibration/tree/added_disableCamera not in main branch of depthai_calibration.
@saching13. Should we use then this branch for now as a calibration submodule?
And when changes are deployed in https://github.com/luxonis/Factory-calibration-DepthAI push them to main?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the same feature is coved here. and no other features are coming from your branch. yes. we can use this branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some features are not set properly in this PR (traceLevel, outputScaleFactor, disableRGB, lensPosition) so I created new PR from main and used changes @CenekAlbl suggested.
#1099

Comment on lines +354 to +376
else:
cameraProperties = self.device.getConnectedCameraFeatures()
calibData = self.device.readCalibration()
eeprom = calibData.getEepromData()
print(f"Product name: {eeprom.productName}, board name {eeprom.boardName}")
detection = eeprom.productName.split()
if "AF" in detection:
detection.remove("AF")
if "FF" in detection:
detection.remove("FF")
if "9782" in detection:
detection.remove("9782")
self.board_name = '-'.join(detection).upper()
board_path = Path(self.board_name)
if not board_path.exists():
board_path = (Path(__file__).parent / 'resources/depthai_boards/boards' / self.board_name.upper()).with_suffix('.json').resolve()
if not board_path.exists():
raise ValueError(
'Board config not found: {}'.format(board_path))
with open(board_path) as fp:
self.board_config = json.load(fp)
self.board_config = self.board_config['board_config']
self.board_config_backup = self.board_config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device.getDeviceName instead of board_name & upper

and cameraProperties & hasAutofocus instead of parsing AF FF etc...

cam_node.initialControl.setChromaDenoise(4)

if cam_info['hasAutofocus']:
cam_node.initialControl.setManualFocus(int(self.args.rgbLensPosition[stringToCam[cam_id].name.lower()]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem well defined.

Lets first define how the mapping is done and then do remapping once and use that throughout the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants