Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with Visual Studio 2022 because cpp-pm/hunter v0.23.258 does not support VS 2022. #313

Closed
yusuke-ota opened this issue Dec 29, 2021 · 2 comments

Comments

@yusuke-ota
Copy link

yusuke-ota commented Dec 29, 2021

Hi.

I'm reporting an error that occurred when I tried to build this project with Visual Studio 2022.

Problem

Currently, the "cpp-pm/hunter v0.23.258" used in this project supports Visual Studio 2019 and earlier.

include("cmake/HunterGate.cmake")
HunterGate(
URL "https://github.com/cpp-pm/hunter/archive/v0.23.258.tar.gz"
SHA1 "062a19ab13ce8dffa9a882b6ce3e43bdabdf75d3"
LOCAL # Local config for dependencies
)

ref: https://github.com/cpp-pm/hunter/blob/286702056cd26b99d1ee95a30327e6ad834bc2ad/cmake/modules/hunter_setup_msvc.cmake#L87-L92

So, I cannot build this project with Visual Studio 2022.

Error:

[hunter ** INTERNAL **] Unexpected MSVC_VERSION: '1930'

Solution

Since "cpp-pm/hunter v0.23.317", "cpp-pm/hunter" supports building with Visual Studio 2022.
And I used v0.23.320 to avoid this error.

I hope you consider upgrading the dependent cpp-pm/hunter in the next update of this project.

Thanks.

@yusuke-ota yusuke-ota changed the title Cannot build using Visual Studio 2022. Cannot build with Visual Studio 2022 because cpp-pm/hunter is not supported. Dec 29, 2021
@yusuke-ota yusuke-ota changed the title Cannot build with Visual Studio 2022 because cpp-pm/hunter is not supported. Cannot build with Visual Studio 2022 because cpp-pm/hunter v0.23.258 does not support VS 2022. Dec 29, 2021
@themarpe
Copy link
Collaborator

@yusuke-ota
Thanks for reporting - great timing, we'll update this before the release as well. We've made necessary changes a while ago, so should be clean update: cpp-pm/hunter#498

@themarpe
Copy link
Collaborator

Updated in 78bbc38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants