Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use next-jdbc #14

Open
yogthos opened this issue May 4, 2020 · 4 comments
Open

update to use next-jdbc #14

yogthos opened this issue May 4, 2020 · 4 comments

Comments

@yogthos
Copy link
Member

yogthos commented May 4, 2020

No description provided.

@javahippie
Copy link
Contributor

javahippie commented Sep 28, 2021

I picked this issue up yesterday in a fork. While testing, I realized that the old clojure.java.jdbc specs which are used to set up the connection won't work with next.jdbc. As these specs potentially contained a lot more information than needed by next.jdbc, it might not be possible to write a converter to the "new" format.

I guess this would make the update a breaking change. If you have some ideas on how to avoid this, or other comments on the code, I'd be happy to discuss.

@yogthos
Copy link
Member Author

yogthos commented Sep 28, 2021

I think it would be worth switching to next.jdbc as a breaking change. If it's not too much work to translate from the current spec to next.jdbc that would be a nice bonus, but it'd mostly be a nice to have convenience. The code looks good, only change I would make would be to use next.jdbc.sql/insert! and next.jdbc.sql/delete! instead of the more general execute.

@javahippie
Copy link
Contributor

Thanks for the comments, I applied the changes.
I will try some more and find a way to convert the basic parameters of the old spec, else I will create a PR without one

@yogthos
Copy link
Member Author

yogthos commented Sep 29, 2021

Fantastic, and thanks again for taking the lead on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants