-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to use next-jdbc #14
Comments
I picked this issue up yesterday in a fork. While testing, I realized that the old clojure.java.jdbc specs which are used to set up the connection won't work with next.jdbc. As these specs potentially contained a lot more information than needed by next.jdbc, it might not be possible to write a converter to the "new" format. I guess this would make the update a breaking change. If you have some ideas on how to avoid this, or other comments on the code, I'd be happy to discuss. |
I think it would be worth switching to next.jdbc as a breaking change. If it's not too much work to translate from the current spec to next.jdbc that would be a nice bonus, but it'd mostly be a nice to have convenience. The code looks good, only change I would make would be to use |
Thanks for the comments, I applied the changes. |
Fantastic, and thanks again for taking the lead on this. |
No description provided.
The text was updated successfully, but these errors were encountered: