Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve explanations of parameters for execute Relay Call guide #662

Merged
merged 4 commits into from
Nov 8, 2023
Merged

improve explanations of parameters for execute Relay Call guide #662

merged 4 commits into from
Nov 8, 2023

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Oct 6, 2023 •
edited
Loading

Screenshot 2023-10-06 at 17 32 56 Screenshot 2023-10-06 at 17 33 03

@frozeman
Copy link
Member

frozeman commented Oct 6, 2023

I think for the validity timestamp it would be good to have a short summary of how the timestamp is constructed:
uinte256<fromTimestamp> + unit12(toTimestamp), e.g.: .....

also what's the nonce nb ?

@frozeman
Copy link
Member

frozeman commented Oct 6, 2023

Also the signWith inter validator should ideally have comment, that explains how that's constructed. so people don't have to look into the code.

@CJ42 CJ42 requested a review from Hugoo as a code owner November 8, 2023 14:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

@CJ42 CJ42 merged commit 89bd6f2 into main Nov 8, 2023
2 checks passed
@CJ42 CJ42 deleted the fix/lsp25-lsp6 branch November 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magalimorin18 magalimorin18 magalimorin18 approved these changes

@fhildeb fhildeb Awaiting requested review from fhildeb

@YamenMerhi YamenMerhi Awaiting requested review from YamenMerhi YamenMerhi is a code owner

@Hugoo Hugoo Awaiting requested review from Hugoo

@b00ste b00ste Awaiting requested review from b00ste b00ste is a code owner

@skimaharvey skimaharvey Awaiting requested review from skimaharvey skimaharvey is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CJ42 @frozeman @magalimorin18