Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New guide for LSP1 URD #627

Merged
merged 12 commits into from
Oct 11, 2023
Merged

New guide for LSP1 URD #627

merged 12 commits into from
Oct 11, 2023

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Sep 15, 2023

  • New 2 parts guide for custom URD in LSP1 category
  • New images

richtera
richtera reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Unfortunately the current release of the extension no longer allows extraction of the private key. We got to fix that; I have a PR for that work, but we want to refactor that code.

@kalote
Copy link
Contributor Author

kalote commented Sep 20, 2023

I need to update the code and the guide following the demo's feedback from Fabian. Do not merge yet.

@Hugoo Hugoo changed the title new guide for LSP1 URD New guide for LSP1 URD Sep 20, 2023
@Hugoo Hugoo marked this pull request as draft September 20, 2023 10:23
@Hugoo
Copy link
Contributor

Hugoo commented Sep 20, 2023

I need to update the code and the guide following the demo's feedback from Fabian. Do not merge yet.

I converted the PR to draft

@kalote
Copy link
Contributor Author

kalote commented Sep 26, 2023

The code of the guide has been updated! It now includes the 2 different methods that has been demonstrated during the demo.
@Hugoo you can remove the "draft" status of this PR and review it!

@Hugoo Hugoo marked this pull request as ready for review September 26, 2023 13:52
CJ42
CJ42 reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice guide, and super to have added so many screenshots! 🥳

I have added some review comments, and will do the other file later.

docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-1.md Outdated Show resolved Hide resolved
CJ42
CJ42 reviewed Oct 10, 2023
View reviewed changes
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
docs/guides/universal-receiver-delegate/create-custom-urd-2.md Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit 52379de into main Oct 11, 2023
2 checks passed
@CJ42 CJ42 deleted the feat/custom-urd branch October 11, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtera richtera richtera left review comments

@CJ42 CJ42 CJ42 approved these changes

@fhildeb fhildeb Awaiting requested review from fhildeb

@Hugoo Hugoo Awaiting requested review from Hugoo

@skimaharvey skimaharvey Awaiting requested review from skimaharvey

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalote @Hugoo @richtera @CJ42