Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-6310_add_ChromeStore_link #594

Merged
merged 2 commits into from
Aug 2, 2023
Merged

DEV-6310_add_ChromeStore_link #594

merged 2 commits into from
Aug 2, 2023

Conversation

biancabuzea200
Copy link
Contributor

No description provided.

@Hugoo
Copy link
Contributor

Hugoo commented Aug 2, 2023

Copy link
Member

@asciiman asciiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


### :inbox_tray: **[Download link (v1.3.3-MV3)](https://storage.googleapis.com/up-browser-extension/universalprofile-extension-v1.3.3-mv3.zip) (Chrome)**

### :inbox_tray: **[Download Archive](https://storage.googleapis.com/up-browser-extension/universalprofile-extension-v1.4.0-mv2.zip) (All other browsers)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asciiman @Hugoo @biancabuzea200 some questions

So this link is always pointing to a specific version of the extension on the chrome store?

question 1: If you release a new version of the extension (e.g: 1.4.18 is the latest with several bug fixes), how can we ensure that the user will download always the latest version when clicking on this button?

question 2: Is there not something like latest?

question 3: also, shouldn't it be mv3 favoured instead of mv2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code on line 48 is not for the chrome store. This is the hardcoded link to google storage for non-chrome browsers. The link to the chrome store is on line 45, and this is always "latest".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means that for non-chrome browsers, we cannot have a "latest" link and will always have to update the link manually?

@CJ42 CJ42 merged commit 1504c93 into main Aug 2, 2023
2 checks passed
@CJ42 CJ42 deleted the chrome-store branch August 2, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants