Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and styling for FAQ #584

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix grammar and styling for FAQ #584

merged 1 commit into from
Jul 12, 2023

Conversation

fhildeb
Copy link
Contributor

@fhildeb fhildeb commented Jul 12, 2023

Community members and I found some minor issues around grammar and styling.

I would like to suggest proofreading the FAQ pages again now that they got released. There might be further grammar issues down the line that were missed due to the huge PR size. 😁

IMO, we should also not use links within headings and rather put them in the text right under them. The bold blue clickable headlines make it hard to navigate across on mobile phones and conquer the unified look and feel.

@fhildeb fhildeb requested a review from Hugoo as a code owner July 12, 2023 16:43
@biancabuzea200
Copy link
Contributor

I think it would be good to get a Grammarly Pro subscription and to run everything through it

Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i agree with no links in the titles 👌

@Hugoo Hugoo merged commit d2a5b08 into main Jul 12, 2023
2 checks passed
@Hugoo Hugoo deleted the faq-grammar-patch branch July 12, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants