-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FAQ - Add Network and Nodes Chapter #574
Conversation
|
||
### What EVM Protocol Upgrades are live on LUKSO? | ||
|
||
The LUKSO Mainnet is up to date with [every Ethereum fork](https://ethereum.org/en/history/) until Shanghai, which was released in 2023. Except for Shapella (Capella and Shanghai), all upgrades were integrated within the mainnet launch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this paragraph is not up to date I believe, as we did the shapella fork few days ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please read again, it is up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Johann is right, the paragraph says Shapella is not activated, but it was a few days ago:
https://github.com/lukso-network/network-configs/blob/main/mainnet/shared/genesis.json#L18
Also @fhildeb for things like that, let's let the person who made the comment write the conversation as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hugoo Alright. But the sentence says that all forks are activated...
The LUKSO Mainnet is up to date with every Ethereum fork until Shanghai, which was released in 2023. Except for Shapella (Capella and Shanghai), all upgrades were integrated within the mainnet launch.
Shanghai is the last fork included in Shapella. 😁 Where does it state Shapella is not activated? The answer states that Shapella was not activated from genesis on, but later. Maybe I should add the timestamp to clear things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i see, i think if both Johann and I got confused, maybe let's just make it more obvious.
Shapella was activated on XXX.
I read it fast and i read: "All were activated EXCEPT shapella".
Let's do maybe:
The LUKSO Mainnet is up to date with [every Ethereum fork](https://ethereum.org/en/history/) until Shanghai, which was released in 2023. Except for Shapella (Capella and Shanghai), all upgrades were integrated within the mainnet launch. | |
The LUKSO Mainnet is up to date with [every Ethereum fork](https://ethereum.org/en/history/) until Shanghai, which was released in 2023. All upgrades were integrated within the mainnet launch, except for Shapella (Capella and Shanghai) which was activated on the 28th of June. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I just rephrased the sentence a bit more to also include the correct block times. (so there is no confusion when we add future forks)
Thanks, Johann, for taking the time 🙏🏻😙 I applied your suggestions and clarified the answers. I also added redirects and modified the headings as in the other sections. |
sadly we now have a few conflicts bc we merged the other PRs :/ should be easy to fi anyway |
Resolved conflicts and added suggestions to the fork question. LGTM 🚀 |
Removes the old Network and Validator pages and sets up the new Network and Nodes folder, including the following pages: