Compat with season mods?

[JorisDeBeer]

Hello, maybe it would be a good idea to make build in compatibility with season and temperature mods? Would make it really immersive.

[lukebemish]

Fabric seasons does not expose any API I can use. Serene seasons is distributed under a restrictive ARR license and thus hard to add compat for without risking issues in the future. As for temperature mods - that really has to be done on their end given what's involved in most cases. I expose an API people can use. If there's specific temperature mods that expose an API I could work with from my end I can look into it but generally speaking it's a lot easier to implement from the other end.

[Steveplays28]

Hi Luke, I'm working on a new seasons mod with Joris, titled Simple Seasons. Would you be up to work together to add compatibility?

I think it'd be super cool to have seasons and regional weather working together, It's something I've wanted to make happen for quite a while!

[lukebemish]

I can add compatibility for a seasons mod pretty easily on my end - basically, I just need some API I can query to get the current season from your mod, and then I'll use that when calculating the weather.

[Steveplays28]

Awesome, thanks. I'll get that in place for you.
I'm also going to look into adding NeoForge multiloader support for 1.20.2 and up for Simple Seasons.

I'll let you know how it goes!

[lostopkk]

Hi Luke, I'm working on a new seasons mod with Joris, titled Simple Seasons. Would you be up to work together to add compatibility?

I think it'd be super cool to have seasons and regional weather working together, It's something I've wanted to make happen for quite a while!

simple seasons looks very promising! I'm looking forward to the stable version of this mod :)

[Steveplays28]

@lostopkk Thanks, glad you like it!

I can add compatibility for a seasons mod pretty easily on my end - basically, I just need some API I can query to get the current season from your mod, and then I'll use that when calculating the weather.

@lukebemish I added an API for fetching the current season per world. It simply returns the season int, which you can check against the SimpleSeasons#Seasons enum, using the value of the enum members.
I still have to make the season be per world instead of serverwide, but I did add the World as an argument for the API so you don't have to worry about changing your implementation immediately when I get to that. I also still need to add JavaDocs.
Does that look good?

Also, FYI, the 1.20.x branch is currently where the main development is happening. I'll switch the branches around sometime. You'll also have to use local Gradle dependencies, see this example: 1, 2, and 3.

For temperature and such, I'm planning on modifying the actual biomes for that, but I still have to look into exactly how to do that. So far I'm only changing precipitation and no actual simulation of temperatures is in place yet. Might be cool to look into for the future, but that might get tricky with compat with Tempest.
If you have any ideas on that, let me know.

[SaltSouls]

Would be nice if we could also get serene seasons support. I believe their mod already has a seasons api that you can hook into.

[lukebemish]

Serene seasons is distributed under a restrictive ARR license and thus hard to add compat for without risking potential legal issues in the future.

[SaltSouls]

Serene seasons is distributed under a restrictive ARR license and thus hard to add compat for without risking potential legal issues in the future.

Really? Cold Sweat has built-in compatibility for it and I haven't heard/seen anything about that being an issue. They even have a whole API section in their code, I assume for people to add interoperability between their mods and Serene Seasons. I believe the legal issues would only occur if you started to try and rip their code/assets and use them in your own mod, instead of using their APIs.

[lukebemish]

They (Serene Seasons) distribute their mod under an "all rights reserved" license. Any mods that depend on their API do so entirely at their own risk and are at constant risk of being told they are violating Serene Season's license

[mosharky]

Their API is supposedly public according to Glitchfiend/SereneSeasons#448. Will compatibility be considered here then?

[lukebemish]

As I already said,

They (Serene Seasons) distribute their mod under an "all rights reserved" license. Any mods that depend on their API do so entirely at their own risk and are at constant risk of being told they are violating Serene Season's license

Whether the API is public or not is unimportant. It is distributed under an ARR license.

[mosharky]

Fair enough I guess, but if it's something you'd like, they're also open to giving explicit permission:

Not sure how much that holds up against an ARR license though

[mosharky]

Any updates on this?