Vertical depth biome placement issues

[Rebel459]

Not sure if this was related to the deep dark issue so made a separate one for it

[Rebel459]

Ah yes, Dark Forest

[lukebemish]

Thanks, I'll poke! Looks like I'm definitely not treating the depth parameter right.

[lukebemish]

Can you share your injections being used?

[Rebel459]

aspen_forest.json
Also, for reference look at the vanilla wiki: depth is a static value of either 0 or 1 for surface biomes, there's definitely something wrong with depth going on here

[Rebel459]

I was only using one injection for testing purposes

[lukebemish]

Uh... You've got a range of 0 to 0.01 on the depth in that injection. That is probably not going to behave as expected, I suspect, given that MC has surface biomes at depth 1.0 (and in cact everywhere outside of predefined ranges in the other parameters). That said, while poking this I did track down the cause of the whole "no deep dark" thing, so hopefully with that in mind I'll be able to put together a fix for both of these with relative ease. I'll get that working when I have a chance.

[Rebel459]

I did it correctly. Surface biomes use 1.0 or 0.0, as per the picture I attached above explaining depth. For surface biomes, it should never be a range but an exact number of either 1 or 0. If you look in the vanilla overworld biome placement file every non-cave biome has a value of both 0 or 1 across it’s many instances

I had 0-0.01 to get as close to accurate as possible, but due to the way depth is currently handled having a correct value is not possible. Both 0 and 1 are valid for surface biomes

[lukebemish]

Uh yeah so there's a bit of a misunderstanding here. The thing you're referring to is "depth value/range of the cuboid defined in the biome space". What I'm referring to -- and the place where biomesquisher actually operates -- is "region of biome space assigned to that biome", which is something like a voronoi cell expanded from the cuboid. By definition, it can't have depth of no range, because then the biome wouldn't exist