Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Light Theme Support #17

Open
shekohex opened this issue Jun 5, 2022 · 3 comments
Open

[Feature Request] Light Theme Support #17

shekohex opened this issue Jun 5, 2022 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@shekohex
Copy link

shekohex commented Jun 5, 2022

Hey! Thank you for the theme! it looks amazing!

I was going to ask if there are any plans to support the light variant of the theme? me myself using the light theme most of the time as it is easier for my eyes to read the dark text on a light background.

I want to start working on adding support for the light theme too, but I would need some help or guidance 😄

Thank you again!

@luisiacc
Copy link
Owner

luisiacc commented Jun 5, 2022

It wasn't in my plan to add a light theme, if you like to give it a try you can try I would totally accept an approach very similar to what is done in https://github.com/folke/tokyonight.nvim

@luisiacc luisiacc added the enhancement New feature or request label Nov 28, 2022
@chriscz
Copy link

chriscz commented May 29, 2023

Hi, was also looking into a light theme since I've switched to tree-sitter for highlighting.

I have been using: https://github.com/sainnhe/gruvbox-material

However I see there is a an alternative lua gruvbox also with treesitter support https://github.com/ellisonleao/gruvbox.nvim (will give it a try and report back)

The reason I switched to light themes was because I was finding it harder and harder to read over time and though I might need glasses, but after making the switch I haven't had issues. Related articles on light vs dark mode benefits:

Edit

  • I'm happy with ellisonleao's gruvbox theme, but I did find that fzf's search result background is still dark. Will have to dig into that when I have some more time :)

@luisiacc
Copy link
Owner

IMO gruvbox theme does not look good on light mode, only on dark mode, therefore I don't really plan to take any action myself into supporting it.

@luisiacc luisiacc added the wontfix This will not be worked on label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants