Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Sort Gcode files by "date modified" or leave them unsorted as provided by host/TFT #386

Closed
rondlh opened this issue Apr 22, 2024 · 7 comments

Comments

@rondlh
Copy link

rondlh commented Apr 22, 2024

Is your feature request related to a problem? Please describe.
Typically I want to print the last file I copied to the USB flash drive in my TFT display when I issue a M20 U: (list USB files).
Unfortunate ESP3D sorts the files alphabetically, so I have to dig around to find the file I want to print.

Describe the solution you'd like
Add an option to 1. sort the files alphabetically, or 2. don't sort them because the TFT handles this already.

Describe alternatives you've considered
This can also be hard coded, then leave it up to Marlin or in my case the TFT to provide the files in the required order (which can be configured).

Additional context
I use ESP3D V3.0, which I can recommend over V2.1

Copy link

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

@kleffa
Copy link

kleffa commented May 7, 2024

https://marlinfw.org/docs/gcode/M020.html
well only in latest Marlin are avaible the time stamp for M20 , so I think they can be sort by date or name

@rondlh
Copy link
Author

rondlh commented Jun 5, 2024

https://marlinfw.org/docs/gcode/M020.html well only in latest Marlin are avaible the time stamp for M20 , so I think they can be sort by date or name

The case you describe is different from my case. I would like to have the option to not sort the files alphabetically, but just display them in the order they are provided. This is because I use a TFT with SD/USB reader that gives me various options to sort the files. But then ESP3D sorts the files again, which makes the TFT sorting useless.

@kleffa
Copy link

kleffa commented Jun 5, 2024

ESP3D didn't sort files, they are just in order provided, which is a Marlin feature, maybe you can try make a better UI to make god lists or change options in marlin to sort them by date

@rondlh
Copy link
Author

rondlh commented Jun 5, 2024

ESP3D sorts the files in src\components\Helpers\filters.js
This has nothing to do with Marlin, because the M20 response is provided by the TFT, not Marlin.

luc-github added a commit that referenced this issue Jul 1, 2024
Add support to select default filesystem when starting in dashboard #394
Fix some glitches in Validation
Remove TFT from CNC/Plotter as no support so far
@luc-github luc-github mentioned this issue Jul 2, 2024
luc-github added a commit that referenced this issue Jul 2, 2024
Add support for enable/disable sorting files #386
Add support to select default filesystem when starting in dashboard #394
Fix some glitches in Validation
Remove TFT from CNC/Plotter as no support so far
Improve dependencies display conditions updating helpers to allow AND conditions in OR group
Fix supported files sytem list missing some depedencies
@luc-github
Copy link
Owner

Fixed by 423dbae

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants