Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node badge feature as it is implemented in core #1051

Closed
wants to merge 2 commits into from

Conversation

huchenlei
Copy link

This PR removes the badge feature from ComfyUI-Manager repo as the feature is now implemented in core (Comfy-Org/ComfyUI_frontend#781).

Please merge this PR after Comfy-Org/ComfyUI_frontend#781 reaches ComfyUI main repo.

image

@ltdrdata
Copy link
Owner

ltdrdata commented Sep 12, 2024

For a while, backward compatibility should be provided for users who are still using older versions of ComfyUI.
Therefore, the deactivation of the badge feature in ComfyUI-Manager needs to be limited to the new front + ComfyUI combination that can use the badge feature.

ltdrdata added a commit that referenced this pull request Sep 18, 2024
@ltdrdata
Copy link
Owner

This is reimplemented.

@ltdrdata ltdrdata closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants