Add null to docblock of minimum and maximum.
#210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `minimum` and `maximum` functions can return null if the $collection is empty. This commit adds to their @return annotation that a null return is a possibility.
|
I am currently adding psalm support (see #208). Since you seem to be using psalm and in case you are interested, feel free to check the |
|
@lstrojny, would it be helpful if I were to make this pull request against the |
|
@jasonmm sure, that would be awesome. In this case though, |
|
This pull request is no longer applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
minimumandmaximumfunctions can return null if the $collection is empty. This commit adds to their @return annotation that a null return is a possibility.I'm not sure if this relates to #208, but psalm does report handling the possibility of a null return with
DocblockTypeContradiction.For example,
maximum([]) ?? -1will produce aDocblockTypeContradiction.