Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46298: Stop using private Butler clone method #445

Merged
merged 1 commit into from
Sep 16, 2024
Merged

DM-46298: Stop using private Butler clone method #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_init_output_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def init_with_pipeline_graph_first(
using the former to actually write init-outputs (with later attempts
correctly failing or doing nothing, depending on parameters).
"""
butler = butler._clone(run=run, collections=[self.INPUT_COLLECTION, run])
butler = butler.clone(run=run, collections=[self.INPUT_COLLECTION, run])
pipeline_graph.init_output_run(butler)
init_output_refs = self.find_init_output_refs(pipeline_graph, butler)
# Build a QG with the init outputs already in place.
Expand Down Expand Up @@ -264,7 +264,7 @@ def init_with_quantum_graph_first(
using the latter to actually write init-outputs (with later attempts
correctly failing or doing nothing, depending on parameters).
"""
butler = butler._clone(run=run, collections=[self.INPUT_COLLECTION, run])
butler = butler.clone(run=run, collections=[self.INPUT_COLLECTION, run])
# Build a QG.
quantum_graph_builder = AllDimensionsQuantumGraphBuilder(
pipeline_graph,
Expand Down Expand Up @@ -316,7 +316,7 @@ def init_with_qbb_first(self, pipeline_graph: PipelineGraph, butler: Butler, run
(with later attempts correctly failing or doing nothing, depending on
parameters).
"""
butler = butler._clone(run=run, collections=[self.INPUT_COLLECTION, run])
butler = butler.clone(run=run, collections=[self.INPUT_COLLECTION, run])
# Build a QG.
quantum_graph_builder = AllDimensionsQuantumGraphBuilder(
pipeline_graph,
Expand Down Expand Up @@ -512,7 +512,7 @@ def test_config_change(self) -> None:
butler.put(DynamicTestPipelineTaskConfig(), "a_config", run="run1")
with self.assertRaises(ConflictingDefinitionError):
pipeline_graph.init_output_run(
butler._clone(run="run1", collections=[self.INPUT_COLLECTION, "run1"])
butler.clone(run="run1", collections=[self.INPUT_COLLECTION, "run1"])
)
quantum_graph_builder = AllDimensionsQuantumGraphBuilder(
pipeline_graph,
Expand All @@ -526,7 +526,7 @@ def test_config_change(self) -> None:
)
with self.assertRaises(ConflictingDefinitionError):
quantum_graph.init_output_run(
butler._clone(run="run1", collections=[self.INPUT_COLLECTION, "run1"])
butler.clone(run="run1", collections=[self.INPUT_COLLECTION, "run1"])
)


Expand Down
Loading