Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45722: CRITICAL logs on empty quantum graph #306

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Aug 29, 2024

This PR fixes a display bug introduced in #305, where pipetask's exit message referred to explanatory logs as CRITICAL instead of ERROR.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The message said explanatory logs were CRITICAL, when they have been
changed to ERROR.
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (1162e18) to head (d69df87).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/lsst/ctrl/mpexec/cli/cmd/commands.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   89.02%   89.00%   -0.03%     
==========================================
  Files          50       50              
  Lines        4439     4439              
  Branches      733      733              
==========================================
- Hits         3952     3951       -1     
  Misses        347      347              
- Partials      140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kfindeisen kfindeisen merged commit e932c7e into main Aug 29, 2024
13 of 15 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-45722-hotfix branch August 29, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants