Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45722: CRITICAL logs on empty quantum graph #305

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

kfindeisen
Copy link
Member

This PR adjusts the unit tests for some behavior changes added in lsst/pipe_base#440.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@kfindeisen kfindeisen requested a review from timj August 28, 2024 02:03
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rerun the action that failed once pipe_base is merged.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (b13e38d) to head (a98f9a2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          50       50           
  Lines        4439     4439           
  Branches      733      733           
=======================================
  Hits         3951     3951           
  Misses        347      347           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kfindeisen kfindeisen merged commit 1162e18 into main Aug 28, 2024
15 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-45722 branch August 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants