Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41165: Prompt processing can't export outputs to /repo/embargo #89

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Oct 12, 2023

This PR uses expanded datasetRefs as inputs to all Butler.transfer_from calls. This is not strictly required after lsst/daf_butler#895, but it helps minimize the overhead associated with the transfers themselves.

@kfindeisen kfindeisen changed the title DM-41165: Prompt processing export fails DM-41165: Prompt processing can't export outputs to /repo/embargo Oct 12, 2023
While the bug where transfer_from required expanded refs has been
fixed, it is still faster to expand the refs at query time. Most of the
extra complexity introduced by expanded refs is on the testing side.
@kfindeisen kfindeisen marked this pull request as ready for review October 17, 2023 20:36
@kfindeisen kfindeisen merged commit 998349b into main Oct 18, 2023
5 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-41165 branch October 18, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants