From 55043740b7a402990a0452286d45d6f2c30d9d48 Mon Sep 17 00:00:00 2001
From: Sean McBride <sean@rogue-research.com>
Date: Sat, 9 Mar 2024 00:09:47 -0500
Subject: [PATCH] Fixed -Wdeprecated-copy-dtor warnings by implementing a copy
 assignment operator (#3306)

Example warning was:

warning: definition of implicit copy assignment operator for 'Group' is deprecated because it has a user-declared destructor [-Wdeprecated-copy-dtor]
---
 c++/src/H5Attribute.cpp | 12 ++++++++++++
 c++/src/H5Attribute.h   |  3 +++
 c++/src/H5Group.cpp     | 12 ++++++++++++
 c++/src/H5Group.h       |  3 +++
 4 files changed, 30 insertions(+)

diff --git a/c++/src/H5Attribute.cpp b/c++/src/H5Attribute.cpp
index e838b4ffb4d..e629a800c76 100644
--- a/c++/src/H5Attribute.cpp
+++ b/c++/src/H5Attribute.cpp
@@ -605,4 +605,16 @@ Attribute::~Attribute()
     }
 }
 
+//--------------------------------------------------------------------------
+// Function:    Copy assignment operator
+Attribute &
+Attribute::operator=(const Attribute &original)
+{
+    if (&original != this) {
+        setId(original.id);
+    }
+
+    return *this;
+}
+
 } // namespace H5
diff --git a/c++/src/H5Attribute.h b/c++/src/H5Attribute.h
index 6851e1ac765..970110274b4 100644
--- a/c++/src/H5Attribute.h
+++ b/c++/src/H5Attribute.h
@@ -78,6 +78,9 @@ class H5_DLLCPP Attribute : public AbstractDs, public H5Location {
     // Destructor: properly terminates access to this attribute.
     virtual ~Attribute() override;
 
+    // Copy assignment operator.
+    Attribute &operator=(const Attribute &original);
+
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
   protected:
     // Sets the attribute id.
diff --git a/c++/src/H5Group.cpp b/c++/src/H5Group.cpp
index 35e9d26bfa3..248e71f9571 100644
--- a/c++/src/H5Group.cpp
+++ b/c++/src/H5Group.cpp
@@ -274,4 +274,16 @@ Group::~Group()
     }
 }
 
+//--------------------------------------------------------------------------
+// Function:    Copy assignment operator
+Group &
+Group::operator=(const Group &original)
+{
+    if (&original != this) {
+        setId(original.id);
+    }
+
+    return *this;
+}
+
 } // namespace H5
diff --git a/c++/src/H5Group.h b/c++/src/H5Group.h
index cb9b0920f84..9c89dd1599a 100644
--- a/c++/src/H5Group.h
+++ b/c++/src/H5Group.h
@@ -67,6 +67,9 @@ class H5_DLLCPP Group : public H5Object, public CommonFG {
     // Destructor
     virtual ~Group() override;
 
+    // Copy assignment operator.
+    Group &operator=(const Group &original);
+
     // Creates a copy of an existing group using its id.
     Group(const hid_t group_id);