Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecated SafeConfigParser resolved #1949

Merged
merged 4 commits into from
Nov 4, 2023
Merged

Conversation

vincentkoc
Copy link
Contributor

Fixes #1948

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

@vincentkoc vincentkoc changed the title fix: Update config.py fix: Deprecated SafeConfigParser resolved Oct 9, 2023
@brendanfalk
Copy link
Contributor

This issues seems to be apparent for a lot of ppl (see #1948). This fix solves it. Would appreciate it getting it merged into main so we don't have to maintain a local fork

@magicwenli
Copy link

Confirmed.

@ChenYuHo
Copy link

@lra

@blueben
Copy link

blueben commented Nov 3, 2023

Any timeline on merge?

@frederikkempe
Copy link

Same. Just bought myself a new Macbook. Desperately waiting for this fix to be able to restore my settings on my new device.

@lra
Copy link
Owner

lra commented Nov 4, 2023

Sorry all, I had to fix all the CI/release pipeline before I could push a new version, I'll try to push a new release tonight.

Copy link
Owner

@lra lra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lra lra merged commit 1797037 into lra:master Nov 4, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Parser deprecated issue
7 participants