[pentest] Move SCA lib into pentest lib #24599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
force-pushed
the
experiment
branch
from
ddf29b2
to
88c6fe6
Compare
nasahlpa
requested review from
pamaury,
vogelpi and
andrea-caforio
and removed request for
a team
andrea-caforio
approved these changes
Sep 24, 2024
nasahlpa
force-pushed
the
experiment
branch
from
88c6fe6
to
654df62
Compare
|
Could I please get an approval for this? |
Currently, we have the SCA lib that is used for the old simpleserial based SCA/FI tests (sw/device/sca) and the new pentest lib that is used for the uJSON based pentest framework (sw/device/tests/penetrationtests). As in the longerm we want to get rid of the old simpleserial framework, this commit merges these two libraries and moves it into the new pentest framework. Moreover, the sca_ suffix is replaced with pentest_. A cleanup of these functions will be conducted once the simpleserial framework is removed. Signed-off-by: Pascal Nasahl <[email protected]>
|
Thanks for the review, @vogelpi. Tests after a rebase are passing, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have the SCA lib that is used for the old simpleserial based SCA/FI tests (sw/device/sca) and the new pentest lib that is used for the uJSON based pentest framework (sw/device/tests/penetrationtests).
As in the longerm we want to get rid of the old simpleserial framework, this commit merges these two libraries and moves it into the new pentest framework.
A cleanup of these functions will be conducted once the simpleserial framework is removed.