Backport Rust topgen changes to ES #19988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of this change is to allow easier integration of generated Rust chip definitions in end-user projects. The following changes remove some issue inherited from the C source file generator. Bellow is a list of changes made to topgen scripts: 1) Add option to generate `derive` for Rust enum 2) Add default Copy and Clone implementations to Rust enum generator 3) Add short type names without TOP_CHIP prefix 4) Remove Rust memory template file 5) Replace Rust top_earlgrey_memory with top_earlgrey in SW Signed-off-by: Michał Mazurek <[email protected]>
* Add generation of compare related traits for enum's in `topgen`. * Fix missing newline between memory addresses and size in template used to generate `top_earlgrey.rs` To check generated data please run Rust topgen: `cd $REPO_TOP` `make -C hw top` `make -C hw topgen_rust_pkg` Signed-off-by: Michał Mazurek <[email protected]>
This commit is used to fill the gap in Rust top level definition after backporting master topgen to earlgrey_es. Signed-off-by: Michał Mazurek <[email protected]>
mazurek-michal
force-pushed
the
backport
branch
from
4ffde67
to
ed6166c
Compare
|
This PR is connected to ongoing effort to write proper driver for |
7 tasks
|
@cfrantz does this look fine from your end? |
cfrantz
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to bring software update to auto-generate top level Rust files in
earlgrey_es.