[earlgrey_es] Cherry-pick - fix phy_host_gran_err test #19707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fatal_err.max with cfg param shared between closed source. Signed-off-by: Jaedon Kim <[email protected]>
eshapira
requested review from
rswarbrick,
sha-ron and
jdonjdon
and removed request for
a team and
rswarbrick
sha-ron
approved these changes
Sep 20, 2023
jdonjdon
approved these changes
Sep 20, 2023
|
@eshapira |
Yes, hopefully now I have the correct way to do it😀 |
rswarbrick
approved these changes
Sep 20, 2023
|
@jdonjdon Can you please take a look on the failing CIs? It's weird that the CIs are failing on this commit after they passed when we committed it to the master branch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit already exists in the master branch, this PR will merge it to earlgrey_es branch.