Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts #191

Open
celynw opened this issue Nov 18, 2020 · 2 comments
Open

Keyboard shortcuts #191

celynw opened this issue Nov 18, 2020 · 2 comments
Labels
area: editor bug Something isn't working

Comments

@celynw
Copy link

celynw commented Nov 18, 2020

(Sorry for opening 3 issues in quick succession! I just like this extension and can see it being a part of my workflow)

Describe the bug
There is a big list of keyboard shortcuts (filter the list by gistpad), which are all unassigned by default.

I wanted to rename gists using F2, like you can with files in the explorer.
There's a command for this, gistpad.renameFile.
When I run this though, I get the warning, Cannot read property 'path' of undefined.
I've tried focusing different things in case it requires a specific 'When' case.

As far as I know, this actually applies to all of them, so perhaps it's just not fully implemented 😄

To Reproduce

  1. Open keyboard shortcuts
  2. Filter the list by gistpad
  3. Assign shortcut to any of these
  4. Try using them.

Expected behavior
They should do carry out the specified action

Screenshots
image

image

Desktop (please complete the following information):

  • VS Code Version: 1.51.1
  • GistPad Version 0.1.9
@celynw celynw added the bug Something isn't working label Nov 18, 2020
@lostintangent
Copy link
Owner

Thanks for reporting this! Many of the GistPad commands are expected to be called from specific contexts, and therefore, wouldn't automatically work when triggered from a keyboard shortcut.

Do you have specific commands that you'd like to be able to trigger via keyboard shortcuts? If so, then I could prioritize getting those to work. Thanks!

@celynw
Copy link
Author

celynw commented Nov 24, 2020

Thank you for the quick response and positivity! 🙇
At a glance, these are the shortcuts I think would be the most useful:

  • gistpad.newScratchNote
  • gistpad.addFileToGist
  • gistpad.addDirectoryFile and gistpad.addFile
  • gistpad.renameDirectory and gistpad.renameFile
  • gistpad.deleteFile

Side note, I'm not sure what the difference is between a 'directory' and a 'gist'.
I thought they might have been the same (separate from repositories), but I can see all gistpad.deleteDirectory, gistpad.deleteGist and gistpad.deleteRepository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: editor bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants