Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeConfigurationRequest doesn't allow empty values #246

Open
sbindzau opened this issue Dec 8, 2023 · 0 comments
Open

ChangeConfigurationRequest doesn't allow empty values #246

sbindzau opened this issue Dec 8, 2023 · 0 comments

Comments

@sbindzau
Copy link

sbindzau commented Dec 8, 2023

I've tried setting values to "" but that fails with OccurenceViolation as the verification considers empty values to be non-existant.

Removing the "validate" for value is one option, but that seemed too much, so I changed "value" in the struct from string to *string to differentiate the cases. Any objections to that, otherwise I can supply a patch with it (needed to change some tests, too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant