Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Apache HttpClient v5 #333

Open
hakanai opened this issue May 4, 2021 · 6 comments · May be fixed by #515
Open

Update to Apache HttpClient v5 #333

hakanai opened this issue May 4, 2021 · 6 comments · May be fixed by #515

Comments

@hakanai
Copy link
Contributor

hakanai commented May 4, 2021

For external reasons we would like to update to Apache HttpClient v5.x, but currently Sardine has a hard dependency on v4.x, which forces us to keep around two implementations of all our HTTP code.

It would be nice if Sardine updated to v5.x also.

@hakanai hakanai changed the title Update to HTTP client v5 Update to Apache HttpClient v5 May 4, 2021
@lookfirst
Copy link
Owner

Sure. PR welcome.

@hakanai
Copy link
Contributor Author

hakanai commented May 6, 2021

I've figured out how to do most of it. Where I'm currently stuck:

  • DefaultRedirectStrategy is very different to before. isRedirectable is gone, as is getRedirect
  • HttpClientContext.TARGET_AUTH_STATE and AuthState itself are both gone
  • RequestAcceptEncoding and ResponseContentEncoding are both gone

Partial work: https://github.com/hakanai/sardine/tree/apache-http5

@ivarmont
Copy link
Contributor

ivarmont commented Oct 7, 2023

I would like to take over this issue, as no update has been given in the last 2 years, would that be ok?

@tprus
Copy link

tprus commented Apr 16, 2024

+1

@dkocher
Copy link
Collaborator

dkocher commented Apr 24, 2024

I would like to take over this issue, as no update has been given in the last 2 years, would that be ok?

Pull requests are definitely welcome.

@PetrusHahol
Copy link

Any updates here? I think it would be great to have http/2 support, but its only achivable by having HttpClient 5

@PetrusHahol PetrusHahol linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants