Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should implement AutoCloseable for streams #213

Open
ooxi opened this issue Jun 16, 2015 · 1 comment
Open

Should implement AutoCloseable for streams #213

ooxi opened this issue Jun 16, 2015 · 1 comment
Labels
enhancement

Comments

@ooxi
Copy link

ooxi commented Jun 16, 2015

I know that clients are not required to call shutdown (why not?) but by extending AutoCloseable you could make sure that all resources get released in a timely fashion.
@dkocher dkocher changed the title Sardine' should extend AutoCloseable' Should implement AutoCloseable for streams Jun 16, 2015
@ooxi
Copy link
Author

ooxi commented Mar 21, 2017

I disagree with the renaming of the issue. The Sardine class itself should implement try-with-resources to help ensuring all resources are released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkocher @ooxi