Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: modal:open and modal:close events #69

Open
brettjonesdev opened this issue Mar 17, 2021 · 0 comments
Open

Feature Request: modal:open and modal:close events #69

brettjonesdev opened this issue Mar 17, 2021 · 0 comments

Comments

@brettjonesdev
Copy link
Contributor

Currently, the Looker Embed exposes a drillmodal:click and dashboard:schedule_modal:open events.

I am currently working on an Embedded Application which has a need to track the open/closed state of Looker Embed modals, in order to update certain components of our host application's UI. Currently, while it is possible to track modal open events in certain cases, there is no corresponding modal:close event which we might use to track the open/closed state.

It would be very helpful if the Embed could expose a single modal:open and corresponding modal:close event to allow for this kind of fine-grained UI integration.

I understand this would not be a feature unique to the Embed SDK, and that it would in fact need to exist within the Embed iframe's application logic itself, but I wasn't sure where to create this feature request if not in this repository. Happy to move this request to wherever it makes the most sense if someone doesn't mind letting me know how to go about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant