Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Hub Auth State returned to looker is saved successfully by Looker but Looker GUI does not recognize this and ends up in an infinite loop of Auth. #529

Open
kosalangoogle opened this issue May 30, 2023 · 2 comments

Comments

@kosalangoogle
Copy link

Trying to create a Custom Action.
Trying to integrate the Google Workspace / Google OAuth / IDP to authenticate.
Can successfully get the OAuth window and Auth in successfully.
The oAuthFetchInfo also successfully gets the state and Looker has the state saved. However, the GUI is not recognizing the event of a successful state / saved state.
This results in the Auth to be stuck in a loop keep asking to Auth in even after a successful Auth.
However, after successful auth, when the GUI asks to auth again immediately if chosen cancel this works as expected and the custom action can be used.

The challenge is if the state expired and requires to auth again hitting cancel causes confusion.

Workaround:
After a successful auth when the GUI shows the window to auth again hit cancel, and refresh the page.

  1. Using a custom Action Server
  2. Create a simple Google IDP Authentication
  3. In version 23.6 the Auth gets successful token and the token is sent to Looker and Looker is saving the state (Proven by working action if the user was to hit cancel on the subsequent Auth Prompt).
  4. The auth will keep on going on a loop, asking use to keep logging in.
@fabio-looker
Copy link
Contributor

Hi @kosalangoogle

I believe the way that this is intended to work is that the action logic should tell Looker whether to present the auth button or not, based on looking at the content of the received state.

Are you able to share a sample request your action is receiving and the associated response you are sending back?

Thanks!

@hrimhari
Copy link

hrimhari commented Jul 4, 2024

Same issue. Looker UI should refresh the form when we click on Verify credentials, but instead it just reverts to the cached Login form it got when we triggered the action.

This only happens to CELL actions. Dashboard and Query actions work as expected.

Also on CELL actions, the form does not properly support Message fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants