-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiscale Logic in direction.py #159
Comments
E.g. for dummy directions that will never self-calibrated anyway.
Sounds good to me. One related issue: I just added a low-res imaging step for patch-type directions (i.e., those that lie outside of the faceted region) that is only done when multiscale clean is activated for selfcal (it's intended to pick up extended emission missed during selfcal so that it's included in the subtraction). We might revisit this once the new logic is implemented, as it might be better to do the low-res image when there is a source larger than 2 arcmin rather than 6 arcmin (i.e., trigger on wavelet module activation rather than on multiscale clean). |
O.K. the logic that decides when to do multiscale cleaning for the facet and when to switch on the wavelet module in pyBDSM is confusing, but not as crazy as I first thought it is...
The current logic is (assuming it isn't set to either
True
orFalse
in the directions file):facetimage_pipeline.parset
it is hardcoded that the wavelet module is always used when imaging the full facet.So shall we change steps 2 and 3 to:
P.S. (*) If there are no sources in the calibrator region, then Factor fails. Even if it is told not to selfcal this facet. Which prompted me to look into this. I'll commit a fix for that once I'm done with this issue.
P.P.S. This supersedes also #39
The text was updated successfully, but these errors were encountered: