Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PosTools #49

Open
AlecThomson opened this issue Apr 22, 2024 · 3 comments
Open

Simplify PosTools #49

AlecThomson opened this issue Apr 22, 2024 · 3 comments

Comments

@AlecThomson
Copy link
Contributor

Hi @maaijke,

There seem to be a few lurking errors in the GitHub here related to casacore and the troubles it can cause with positional info. Further, there is a quite a bulk of code to maintain in the related PosTools.py. In there there is a switch as well to use either casacore or ephem.

Looking at the code, I think that a bunch could be replaced with calls to the appropriate astropy.coordinates and the appropriate frames. What do you think?

@maaijke
Copy link
Collaborator

maaijke commented Apr 22, 2024

Also here, this is something I have been wanting to implement for quite some time now. It would be good to become completely independent of both pyephem and casacore (apart from the MS interface)

@AlecThomson
Copy link
Contributor Author

Glad to see that RMextract is being 'modernized' :) So you might want to replace PyEphem interface with SkyField as PyEphem is no longer being supported. Although super-accurate positions are not all that critical for ionosphere modeling.

@twillis449 is there any reason this can't be done with vanilla astropy?

@twillis449
Copy link
Collaborator

You are quite correct - astropy should be able to do anything SkyField does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants