Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mylogger.py removes all existing logging handlers #233

Open
zack466 opened this issue Jun 25, 2024 · 0 comments
Open

mylogger.py removes all existing logging handlers #233

zack466 opened this issue Jun 25, 2024 · 0 comments

Comments

@zack466
Copy link

zack466 commented Jun 25, 2024

I noticed that in mylogger.py, when init_logger() is called, it removes all existing handlers from the root logger (source). However, this means that when pybdsf is called from a scripting context, it deletes all of the existing logging handlers set up by the calling code, completely eliminating all non-pybdsf logging logic. This is very unexpected and definitely should not happen. I think it would be helpful to assign constant names to the pybdsf-specific logging handlers and only remove those named handlers from the root logger in init_logger() rather than all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant