Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake_minimum_required is too low for features used #309

Open
basvandertol opened this issue Sep 21, 2020 · 4 comments
Open

cmake_minimum_required is too low for features used #309

basvandertol opened this issue Sep 21, 2020 · 4 comments

Comments

@basvandertol
Copy link
Collaborator

Commits 2401a19 and 194c238 (development branch) introduce the usage of the cmake command file(CREATE_LINK ...)
This feature was only introduced in CMake 3.14, while the cmake_minimum_required version set in the toplevel CMake file is 3.9

Either do not use this feature, or update the minimum required version accordingly.

./DDECal/test/integration/CMakeLists.txt:file(CREATE_LINK ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}/source
./DPPP/test/integration/CMakeLists.txt:file(CREATE_LINK ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}/source

@mhardcastle
Copy link

Agreed, please remove use of this feature, it breaks build compatibility with stock Debian buster base images.

@aroffringa
Copy link
Contributor

This is to be fixed in https://git.astron.nl/RD/DP3/-/merge_requests/295 .

@mhardcastle unless you need recent features, which I suspect is not the case, you don't have to use master - we generally recommend to use only released versions for 'production' like usage.

@mhardcastle
Copy link

Yes, I have backed off to v4.2.0 now. Using master does allow me to find out what's coming down the track that might cause problems later!

@aroffringa
Copy link
Contributor

True -- and actually I highly appreciate bug reports before new versions are released :).

tammojan pushed a commit that referenced this issue Nov 30, 2020
Fixes #309 . As far as I can tell, the created source links were not used yet -- at least all integration tests run fine locally without these statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants