-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake_minimum_required is too low for features used #309
Comments
Agreed, please remove use of this feature, it breaks build compatibility with stock Debian buster base images. |
This is to be fixed in https://git.astron.nl/RD/DP3/-/merge_requests/295 . @mhardcastle unless you need recent features, which I suspect is not the case, you don't have to use master - we generally recommend to use only released versions for 'production' like usage. |
Yes, I have backed off to v4.2.0 now. Using master does allow me to find out what's coming down the track that might cause problems later! |
True -- and actually I highly appreciate bug reports before new versions are released :). |
Fixes #309 . As far as I can tell, the created source links were not used yet -- at least all integration tests run fine locally without these statements.
Commits 2401a19 and 194c238 (development branch) introduce the usage of the cmake command
file(CREATE_LINK ...)
This feature was only introduced in CMake 3.14, while the cmake_minimum_required version set in the toplevel CMake file is 3.9
Either do not use this feature, or update the minimum required version accordingly.
The text was updated successfully, but these errors were encountered: