Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message "You have cancelled the order..." should rather be "Order<orderId> has been cancelled..." #482

Closed
knocte opened this issue Mar 4, 2024 · 1 comment · Fixed by #601
Closed

Message "You have cancelled the order..." should rather be "Order<orderId> has been cancelled..." #482

knocte opened this issue Mar 4, 2024 · 1 comment · Fixed by #601
Assignees
@knocte

Comments

@knocte
Copy link
Contributor

knocte commented Mar 4, 2024 •
edited
Loading

Describe the bug
When seller cancels an order that a buyer just took, the bot messages the buyer saying "you have cancelled the order" instead of messaging the seller.

To Reproduce
Steps to reproduce the behavior:

  1. Seller sets an order to sell some sats.
  2. Buyer takes the order to buy the sats.
  3. Bot asks buyer to give it an invoice for the sats.
  4. Before buyer gives the invoice, seller cancels the order.

Current behaviour
Bots sends a msg to buyer saying "You have cancelled the order..."

Expected behavior
Bot should send a msg to buyer saying "Order xyz has been cancelled, no need to create an invoice.", and send a msg to seller saying "You have cancelled the order..."

Smartphone (please complete the following information):

  • OS: Android (both buyer and seller were using Android when reproducing this bug, but anyway I guess the OS is not related)
@knocte knocte changed the title Message "You have cancelled the order..." should rather be "Order ... has been cancelled..." Message "You have cancelled the order..." should rather be "Order<orderId> has been cancelled..." Mar 5, 2024
Mersho added a commit to Mersho/bot that referenced this issue Mar 13, 2024
@Mersho
commands: inform buyer when order is canceled
61a631f 
When the seller cancels an order, the buyer will get a wrong
and confusing message:

```
You have cancelled the order ID: orderID
```

So, in this commit, the bot sends a message that
tells the buyer:

```
Order orderId has been cancelled. There is no need to create an invoice.
```

Fixes: lnp2pBot#482
knocte pushed a commit to knocte/lnp2pBot that referenced this issue May 13, 2024
@Mersho @knocte
commands: inform buyer when order is canceled
d2578aa 
When the seller cancels an order, the buyer will get a wrong
and confusing message:

```
You have cancelled the order ID: orderID
```

So, in this commit, the bot sends a message that
tells the buyer:

```
Order orderId has been cancelled. There is no need to create an invoice.
```

Fixes: lnp2pBot#482
knocte pushed a commit to knocte/lnp2pBot that referenced this issue May 13, 2024
@Mersho @knocte
commands: inform buyer when order is canceled
f566dab 
When the seller cancels an order, the buyer was getting a
confusing message:

```
You have cancelled the order ID: orderID
```

Now the bot sends a message that tells the buyer:

```
Order orderId has been cancelled. There is no need to create an invoice.
```

Fixes: lnp2pBot#482
@knocte knocte mentioned this issue May 13, 2024
Closed
@Catrya
Copy link
Member

Catrya commented Aug 5, 2024

This bug also happens when a buyer (maker) cancels an order before the seller pays the invoice

@Catrya Catrya mentioned this issue Oct 26, 2024
Merged
knocte pushed a commit to knocte/lnp2pBot that referenced this issue Nov 12, 2024
@Mersho @knocte
commands: inform buyer when order is canceled
c743264 
When the seller cancels an order, the buyer was getting a
confusing message:

```
You have cancelled the order ID: orderID
```

Now the bot sends a message that tells the buyer:

```
Order orderId has been cancelled. There is no need to create an invoice.
```

Fixes: lnp2pBot#482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knocte knocte

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@knocte @Catrya