Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add currency conversion #36

Open
meeDamian opened this issue Jan 27, 2019 · 2 comments
Open

Add currency conversion #36

meeDamian opened this issue Jan 27, 2019 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@meeDamian
Copy link
Member

Should we?

Or maybe just an extra endpoint returning exchange rates?

Or extra /fiatInvoice endpoint?

@meeDamian meeDamian added enhancement New feature or request question Further information is requested labels Jan 27, 2019
@nolim1t
Copy link
Member

nolim1t commented Jan 28, 2019

I don't think we should add fiat to it. The end game for bitcoin is to make fiat "irrelephant".

I think calling an API to get the rates will suffice for now. Should merchants not want to have too much expose (again not an issue now), they can all another API from an exchange of their choice and see what sort of rates they can get at the time.

@meeDamian
Copy link
Member Author

Good point.

BUT, someone has to do it. Currently fronted does it, but given it might be useful to at least a few fronteds, it might make sense to have it handled by backend.

I agree it doesn't make sense to go out of our way to get it to work, but I know some free APIs and we can easily have an extra endpoint that supports at least a few currencies we care about.

Happy to discuss it further, however.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants