[libc] newheadergen: adding h_def_file arg to test #99397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaryanshukla
commented
Jul 17, 2024
aaryanshukla
commented
- spacing with _NOEXCEPT
- spacing with _NOEXCEPT
|
@llvm/pr-subscribers-libc Author: None (aaryanshukla) Changes
Full diff: https://github.com/llvm/llvm-project/pull/99397.diff 2 Files Affected:
diff --git a/libc/newhdrgen/tests/output/test_small.h b/libc/newhdrgen/tests/output/test_small.h
index a777976134b04..a1ed28e391ffd 100644
--- a/libc/newhdrgen/tests/output/test_small.h
+++ b/libc/newhdrgen/tests/output/test_small.h
@@ -28,20 +28,20 @@ enum {
__BEGIN_C_DECLS
-CONST_FUNC_A void func_a() __NOEXCEPT;
+CONST_FUNC_A void func_a()__NOEXCEPT;
#ifdef LIBC_TYPES_HAS_FLOAT128
float128 func_b() __NOEXCEPT;
#endif // LIBC_TYPES_HAS_FLOAT128
#ifdef LIBC_TYPES_HAS_FLOAT16
-_Float16 func_c(int, float) __NOEXCEPT;
+_Float16 func_c(int, float)__NOEXCEPT;
-_Float16 func_d(int, float) __NOEXCEPT;
+_Float16 func_d(int, float)__NOEXCEPT;
#endif // LIBC_TYPES_HAS_FLOAT16
#ifdef LIBC_TYPES_HAS_FLOAT16_AND_FLOAT128
-_Float16 func_e(float128) __NOEXCEPT;
+_Float16 func_e(float128)__NOEXCEPT;
#endif // LIBC_TYPES_HAS_FLOAT16_AND_FLOAT128
extern obj object_1;
diff --git a/libc/newhdrgen/tests/test_integration.py b/libc/newhdrgen/tests/test_integration.py
index f12d18bc04a49..628a37b11c309 100644
--- a/libc/newhdrgen/tests/test_integration.py
+++ b/libc/newhdrgen/tests/test_integration.py
@@ -25,6 +25,7 @@ def run_script(self, yaml_file, h_def_file, output_dir):
"python3",
str(self.source_dir / "libc/newhdrgen/yaml_to_classes.py"),
str(yaml_file),
+ "--h_def_file",
str(h_def_file),
"--output_dir",
str(output_dir),
|
| @@ -28,20 +28,20 @@ enum { | |||
|
|
|||
| __BEGIN_C_DECLS | |||
|
|
|||
| CONST_FUNC_A void func_a() __NOEXCEPT; | |||
| CONST_FUNC_A void func_a()__NOEXCEPT; | |||
There was a problem hiding this comment.
I think this should have spaces still
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
michaelrj-google
approved these changes
Jul 17, 2024
sgundapa
pushed a commit
to sgundapa/upstream_effort
that referenced
this pull request
Jul 23, 2024
- spacing with _NOEXCEPT
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: - spacing with _NOEXCEPT Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.