Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang] Fix broken atan_real16 test #98499

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tarunprabhu
Copy link
Contributor

The names in the end function were incorrect. Those have been removed.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Jul 11, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 11, 2024

@llvm/pr-subscribers-flang-fir-hlfir

Author: Tarun Prabhu (tarunprabhu)

Changes

The names in the end function were incorrect. Those have been removed.


Full diff: https://github.com/llvm/llvm-project/pull/98499.diff

1 Files Affected:

  • (modified) flang/test/Lower/Intrinsics/atan_real16.f90 (+2-2)
diff --git a/flang/test/Lower/Intrinsics/atan_real16.f90 b/flang/test/Lower/Intrinsics/atan_real16.f90
index 3ae037307c32b..292091463b01d 100644
--- a/flang/test/Lower/Intrinsics/atan_real16.f90
+++ b/flang/test/Lower/Intrinsics/atan_real16.f90
@@ -6,7 +6,7 @@
 function test_real16(x)
   real(16) :: x, test_real16
   test_real16 = atan(x)
-end function real16
+end function test_real16
 
 ! CHECK-LABEL: @_QPtest_real16
 ! CHECK: fir.call @_FortranAAtanF128({{.*}}){{.*}}: (f128) -> f128
@@ -14,7 +14,7 @@ end function real16
 function test_real16_2(y, x)
   real(16) :: y, x, test_real16
   test_real16 = atan(y, x)
-end function real16_2
+end function test_real16_2
 
 ! CHECK-LABEL: @_QPtest_real16
 ! CHECK: fir.call @_FortranAAtan2F128({{.*}}){{.*}}: (f128, f128) -> f128

@klausler
Copy link
Contributor

Can you please merge this?

@tarunprabhu tarunprabhu merged commit cfeb8f2 into llvm:main Jul 11, 2024
5 of 6 checks passed
@tarunprabhu tarunprabhu deleted the fix-atan-real16-test branch July 11, 2024 21:17
aaryanshukla pushed a commit to aaryanshukla/llvm-project that referenced this pull request Jul 14, 2024
The names in the `end function` were incorrect. Those have been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants