-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM][test][nfc] Updating test to work with internal shell #98370
Conversation
The RUN line attempts to set the JITDUMPDIR environment variable, which fails in llvm-lit's internal shell. This patch prefixes JITDUMPDIR with env so that the behavior of setting the variable is as expected in the internal shell.
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
cc: @ilovepi @petrhosek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll land this after premerge checks pass.
Actually can we change the commit title to something like “Update test to work with internal shell”? The current title isn’t all that informative IMO. You should be able to do that with just the edit button above. |
@connieyzhu Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
The RUN line attempts to set the JITDUMPDIR environment variable, which fails in llvm-lit's internal shell. This patch prefixes JITDUMPDIR with env so that the behavior of setting the variable is as expected in the internal shell.
The RUN line attempts to set the JITDUMPDIR environment variable, which fails in llvm-lit's internal shell. This patch prefixes JITDUMPDIR with env so that the behavior of setting the variable is as expected in the internal shell.
Fixes #102395