-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SandboxIR] Add BasicBlock and adds functionality to Function and Context #97637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschuett
reviewed
Jul 4, 2024
tschuett
reviewed
Jul 4, 2024
aeubanks
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: git commit titles are usually imperative, e.g. Add ...
instead of Adds ...
vporpo
changed the title
[SandboxIR] Adds BasicBlock and adds functionality to Function and Context
[SandboxIR] Add BasicBlock and adds functionality to Function and Context
Jul 8, 2024
aeubanks
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg with comments addressed
…text We can now create SandboxIR from LLVM IR using the Context::create* functions.
vporpo
force-pushed
the
SBVec
branch
2 times, most recently
from
July 8, 2024 22:45
5b6b8ae
to
1b7a0cf
Compare
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
…text (llvm#97637) We can now create SandboxIR from LLVM IR using the Context::create* functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now create SandboxIR from LLVM IR using the Context::create* functions.