Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SandboxIR] Add BasicBlock and adds functionality to Function and Context #97637

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Jul 3, 2024

We can now create SandboxIR from LLVM IR using the Context::create* functions.

Copy link
Contributor

@aeubanks aeubanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: git commit titles are usually imperative, e.g. Add ... instead of Adds ...

llvm/include/llvm/SandboxIR/SandboxIR.h Outdated Show resolved Hide resolved
llvm/lib/SandboxIR/SandboxIR.cpp Outdated Show resolved Hide resolved
llvm/lib/SandboxIR/SandboxIR.cpp Outdated Show resolved Hide resolved
llvm/include/llvm/SandboxIR/SandboxIR.h Outdated Show resolved Hide resolved
llvm/include/llvm/SandboxIR/SandboxIR.h Show resolved Hide resolved
llvm/include/llvm/SandboxIR/SandboxIR.h Outdated Show resolved Hide resolved
llvm/lib/SandboxIR/SandboxIR.cpp Outdated Show resolved Hide resolved
llvm/lib/SandboxIR/SandboxIR.cpp Outdated Show resolved Hide resolved
llvm/include/llvm/SandboxIR/SandboxIR.h Outdated Show resolved Hide resolved
@vporpo vporpo changed the title [SandboxIR] Adds BasicBlock and adds functionality to Function and Context [SandboxIR] Add BasicBlock and adds functionality to Function and Context Jul 8, 2024
Copy link
Contributor

@aeubanks aeubanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg with comments addressed

llvm/include/llvm/SandboxIR/SandboxIR.h Outdated Show resolved Hide resolved
llvm/lib/SandboxIR/SandboxIR.cpp Outdated Show resolved Hide resolved
…text

We can now create SandboxIR from LLVM IR using the Context::create* functions.
@vporpo vporpo force-pushed the SBVec branch 2 times, most recently from 5b6b8ae to 1b7a0cf Compare July 8, 2024 22:45
@vporpo vporpo merged commit 50881d0 into llvm:main Jul 9, 2024
10 checks passed
@vporpo vporpo deleted the SBVec branch July 9, 2024 03:13
aaryanshukla pushed a commit to aaryanshukla/llvm-project that referenced this pull request Jul 14, 2024
…text (llvm#97637)

We can now create SandboxIR from LLVM IR using the Context::create*
functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants