Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DXIL] Add GroupMemoryBarrierWithGroupSync intrinsic #114349

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

adam-yang
Copy link
Contributor

fixes #112974
partially fixes #70103

This change was reverted so some issues could be fixed.

Changes

  • Added new tablegen based way of lowering dx intrinsics to DXIL ops.
  • Added int_dx_group_memory_barrier_with_group_sync intrinsic in IntrinsicsDirectX.td
  • Added expansion for int_dx_group_memory_barrier_with_group_sync in DXILIntrinsicExpansion.cpp`
  • Added DXIL backend test case

Related PRs

@adam-yang
Copy link
Contributor Author

Regarding the warnings:

  • The switch which covers all enumeration values warning was resolved by removing the default.
  • The must specify at least one argument for '...' parameter of variadic macro warning was resolved by doing what DXIL_OP_FUNCTION_TYPE did, which used the same variadic parameter mechanism, but leaves empty ones like DXIL_OP_FUNCTION_TYPE(dxil::OpCode::WaveIsFirstLane, dxil::OpParamType::Int1Ty, ) which satisfies the compiler.

@adam-yang adam-yang marked this pull request as ready for review October 31, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant