Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Call base class method in DarwinAArch64TargetInfo::getOSDefines #114241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahatanak
Copy link
Collaborator

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category backend:AArch64 clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Oct 30, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 30, 2024

@llvm/pr-subscribers-backend-aarch64

@llvm/pr-subscribers-clang

Author: Akira Hatanaka (ahatanak)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/114241.diff

1 Files Affected:

  • (modified) clang/lib/Basic/Targets/AArch64.cpp (+1-1)
diff --git a/clang/lib/Basic/Targets/AArch64.cpp b/clang/lib/Basic/Targets/AArch64.cpp
index a0f94d5d315480..e9c1917ccbf060 100644
--- a/clang/lib/Basic/Targets/AArch64.cpp
+++ b/clang/lib/Basic/Targets/AArch64.cpp
@@ -1716,7 +1716,7 @@ void DarwinAArch64TargetInfo::getOSDefines(const LangOptions &Opts,
   if (Triple.isArm64e())
     Builder.defineMacro("__arm64e__", "1");
 
-  getDarwinDefines(Builder, Opts, Triple, PlatformName, PlatformMinVersion);
+  DarwinTargetInfo<AArch64leTargetInfo>::getOSDefines(Opts, Triple, Builder);
 }
 
 TargetInfo::BuiltinVaListKind

@JOE1994
Copy link
Member

JOE1994 commented Oct 30, 2024

What's the motivation for this change?

@ahatanak ahatanak changed the title [NFC} Call base class method in DarwinAArch64TargetInfo::getOSDefines [NFC] Call base class method in DarwinAArch64TargetInfo::getOSDefines Oct 30, 2024
@ahatanak
Copy link
Collaborator Author

This is needed for a private patch we'll be upstreaming in the future. Even without that, I think it's an improvement over what we are doing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants