Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailcall optimization and register preservation produces miscompile #97758

Closed
gerben-stavenga opened this issue Jul 4, 2024 · 2 comments · Fixed by #112098
Closed

Tailcall optimization and register preservation produces miscompile #97758

gerben-stavenga opened this issue Jul 4, 2024 · 2 comments · Fixed by #112098
Assignees
@antoniofrighetto
Labels
backend:X86 miscompilation

Comments

@gerben-stavenga
Copy link

Tailcall optimization moves call out of the push/pop scope to preserve registers

https://godbolt.org/z/1zdnK96z6
@antoniofrighetto antoniofrighetto self-assigned this Jul 5, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 5, 2024

@llvm/issue-subscribers-backend-x86

Author: None (gerben-stavenga)

Tailcall optimization moves call out of the push/pop scope to preserve registers

https://godbolt.org/z/1zdnK96z6

@gerben-stavenga
Copy link
Author

Btw. It's not only that it moves the call out of push/pop scope. It also doesn't set up the registers properly it misses the 3rd argument in rdx

antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this issue Oct 12, 2024
@antoniofrighetto
[X86] Do not elect to tail call if caller must preserve all registers
ec6b311 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
@antoniofrighetto antoniofrighetto mentioned this issue Oct 12, 2024
Merged
antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this issue Oct 12, 2024
@antoniofrighetto
[X86] Do not elect to tail call if caller must preserve all registers
0c9ca09 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this issue Oct 16, 2024
@antoniofrighetto
[X86] Do not elect to tail call if caller must preserve all registers
0578948 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
antoniofrighetto added a commit to antoniofrighetto/llvm-project that referenced this issue Oct 16, 2024
@antoniofrighetto
[X86] Do not elect to tail call if caller must preserve all registers
4035788 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this issue Oct 16, 2024
@antoniofrighetto @bricknerb
[X86] Do not elect to tail call if caller must preserve all registers
dd965cd 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this issue Oct 17, 2024
@antoniofrighetto @bricknerb
[X86] Do not elect to tail call if caller must preserve all registers
f80571c 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
EricWF pushed a commit to efcs/llvm-project that referenced this issue Oct 22, 2024
@antoniofrighetto @EricWF
[X86] Do not elect to tail call if caller must preserve all registers
29455c8 
A miscompilation issue has been addressed with improved checking.

Fixes: llvm#97758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoniofrighetto antoniofrighetto

Labels
backend:X86 miscompilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[X86] Do not elect to tail call if caller must preserve all registers antoniofrighetto/llvm-project
4 participants
@EugeneZelenko @antoniofrighetto @gerben-stavenga @llvmbot