Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport [AArch64] Support for Ampere1 core #55244

Closed
ptomsich opened this issue May 3, 2022 · 10 comments
Closed

Backport [AArch64] Support for Ampere1 core #55244

ptomsich opened this issue May 3, 2022 · 10 comments
Labels
backend:AArch64 release:backport

Comments

@ptomsich
Copy link
Contributor

ptomsich commented May 3, 2022

64816e6 [AArch64] Add native CPU detection for Ampere1
7e02bc5 [AArch64] Support for Ampere1 core

This adds support for the Ampere1 core to the 14.0.x series to support using the same Makefiles/scripts as with GCC (and the future LLVM 15).

Cherry-picked and tested w/o regressions against llvmorg-14.0.1

@kbeyls @davemgreen Ok to backport?
@llvmbot
Copy link
Collaborator

llvmbot commented May 3, 2022

@llvm/issue-subscribers-backend-aarch64

@kbeyls
Copy link
Collaborator

kbeyls commented May 4, 2022

I see no issue with backporting these 2 patches, so it's OK from my perspective.

@ptomsich ptomsich added this to the LLVM 14.0.2 Release milestone May 4, 2022
@ptomsich
Copy link
Contributor Author

ptomsich commented May 4, 2022

/cherry-pick 7e02bc5 64816e6

@llvmbot
Copy link
Collaborator

llvmbot commented May 4, 2022

/branch llvmbot/llvm-project/issue55244

@llvmbot llvmbot mentioned this issue May 4, 2022
Open
@llvmbot
Copy link
Collaborator

llvmbot commented May 4, 2022

/pull-request llvmbot#190

@ptomsich
Copy link
Contributor Author

ptomsich commented May 9, 2022

Turns out that the MTE extension was turned on for Ampere1, which shouldn't have been.

So the following should additionally be included in the backport:
91b24b0 [AArch64] Ampere1 does not support MTE

@ptomsich
Copy link
Contributor Author

ptomsich commented May 9, 2022

/cherry-pick 91b24b0

@llvmbot
Copy link
Collaborator

llvmbot commented May 9, 2022

Failed to cherry-pick: 91b24b0

https://github.com/llvm/llvm-project/actions/runs/2293275504

Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:

/branch <user>/<repo>/<branch>

@ptomsich
Copy link
Contributor Author

ptomsich commented May 9, 2022

/cherry pick 7e02bc5 64816e6 91b24b0

@ptomsich ptomsich closed this as completed May 9, 2022
@ptomsich ptomsich mentioned this issue May 9, 2022
Closed
@tstellar
Copy link
Collaborator

Duplicate of #55349

@tstellar tstellar marked this as a duplicate of #55349 May 11, 2022
@tstellar tstellar removed this from the LLVM 14.0.4 Release milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend:AArch64 release:backport
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tstellar @EugeneZelenko @ptomsich @kbeyls @llvmbot