-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flang][libc++][regression] Flang runtime cannot be built after merging PR #109151 #113059
Comments
To make the solution work with both older and newer libc++ versions, can we provide the function in two overloaded forms - both with and without |
Moving the discussion from #109151 (comment)
Understood. But why don't they want to link against the standard library? Using the libc++ headers without linking against libc++ is not supported, and it fails in various ways. For example, we externally instantiate various templates like member functions of |
Indeed, that's understandably not supported. See https://reviews.llvm.org/D158957 for earlier discussion on this - as far as I understand, the flang runtime wants to take their chances and use some subsets of the C++ standard library as a convenience, expecting to use only some, header-only classes, while not linking against it. That's of course nothing that libc++ can support, but explains the current situation. |
CC @mmuetzel Is there a reason why you try to control how you compile and link against the C++ standard library? If you just use whatever comes by default with your compiler (i.e. you drop |
If I understand correctly, that is something that the flang driver does. |
Maybe, @klausler can give feedback on how the flang runtime is supposed to use the C++ runtime and the motivation for that? |
The following change is needed to make the flang runtime build again after #109151 has been merged:
The text was updated successfully, but these errors were encountered: