Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++][test] fp_compare.h includes non-portable <__config> #105878

Closed
StephanTLavavej opened this issue Aug 23, 2024 · 0 comments · Fixed by #106080
Closed

[libc++][test] fp_compare.h includes non-portable <__config> #105878

StephanTLavavej opened this issue Aug 23, 2024 · 0 comments · Fixed by #106080
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite

Comments

@StephanTLavavej
Copy link
Member

Introduced by #100820:

llvm-project/libcxx/test/support/fp_compare.h

Line 15 in 52a7116

#include <__config>

Found while running libc++'s tests with MSVC's STL, which naturally lacks this libc++ internal header.
@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 23, 2024
@StephanTLavavej StephanTLavavej mentioned this issue Aug 24, 2024
Merged
ldionne added a commit to ldionne/llvm-project that referenced this issue Aug 26, 2024
@ldionne
[libc++] Avoid including <__config> directly in the test suite
e63394b 
Fixes llvm#105878
@ldionne ldionne mentioned this issue Aug 26, 2024
Merged
ldionne added a commit that referenced this issue Aug 26, 2024
@ldionne
[libc++] Avoid including <__config> directly in the test suite (#106080)
06edc1c 
Fixes #105878
5c4lar pushed a commit to 5c4lar/llvm-project that referenced this issue Aug 29, 2024
@ldionne @5c4lar
[libc++] Avoid including <__config> directly in the test suite (llvm#…
2ff56ab 
…106080)

Fixes llvm#105878
dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this issue Sep 2, 2024
@ldionne @dmpolukhin
[libc++] Avoid including <__config> directly in the test suite (llvm#…
c78d4b7 
…106080)

Fixes llvm#105878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc++] Avoid including <__config> directly in the test suite ldionne/llvm-project
2 participants
@StephanTLavavej @EugeneZelenko