From ad016352ec61af1df87e5e46fcfcbd1bef9ba4dd Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 10 Jul 2024 08:53:03 -0500 Subject: [PATCH] [libc++] Fix sized deallocation comments in tests (#98173) Clang 19 turned on sized deallocation *by default*, but older versions of Clang did support sized deallocation nonetheless. This updates a few comments and removes UNSUPPORTED annotations that shouldn't be needed in a test that passes -fsized-deallocation directly. --- .../support.dynamic/libcpp_deallocate.sh.cpp | 5 +---- .../new.delete.array/sized_delete_array14.pass.cpp | 2 +- .../new.delete/new.delete.single/sized_delete14.pass.cpp | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp b/libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp index ef04ccddf1835c..37e3f8167051aa 100644 --- a/libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp +++ b/libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// -// test libc++'s implementation of align_val_t, and the relevant new/delete +// Test libc++'s implementation of align_val_t, and the relevant new/delete // overloads in all dialects when -faligned-allocation is present. // Libc++ when built for z/OS doesn't contain the aligned allocation functions, @@ -21,9 +21,6 @@ // GCC doesn't support the aligned-allocation flags. // XFAIL: gcc -// These compiler versions do not have proper sized deallocation support. -// UNSUPPORTED: clang-17, clang-18 - // RUN: %{build} -faligned-allocation -fsized-deallocation // RUN: %{run} // RUN: %{build} -faligned-allocation -fno-sized-deallocation -DNO_SIZE diff --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp index dc8254680310cd..01467ca9911e10 100644 --- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp +++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp @@ -8,7 +8,7 @@ // test sized operator delete[] replacement. -// These compiler versions do not have proper sized deallocation support. +// These compiler versions don't enable sized deallocation by default. // UNSUPPORTED: clang-17, clang-18 // UNSUPPORTED: sanitizer-new-delete, c++03, c++11 diff --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp index a03fc9f3e8266e..fd7f2dbabdacc8 100644 --- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp +++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp @@ -6,9 +6,9 @@ // //===----------------------------------------------------------------------===// -// test sized operator delete replacement. +// Test sized operator delete replacement. -// These compiler versions do not have proper sized deallocation support. +// These compiler versions do not enable sized deallocation by default. // UNSUPPORTED: clang-17, clang-18 // UNSUPPORTED: sanitizer-new-delete, c++03, c++11