From a6ad95d7861d28063d79afd97e75fd6ca33b8c30 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 17 Jul 2024 19:39:04 -0700 Subject: [PATCH] Rapply "[Target] Use range-based for loops (NFC) (#98844)" Summary: This iteration drops hunks where the loop body adds more elements. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250862 --- llvm/lib/Target/ARM/ARMFrameLowering.cpp | 4 ++-- llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp | 4 ++-- llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp | 4 ++-- llvm/lib/Target/Hexagon/HexagonGenInsert.cpp | 12 ++++++------ llvm/lib/Target/Mips/MipsFastISel.cpp | 4 ++-- llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp | 4 ++-- llvm/lib/Target/PowerPC/PPCEarlyReturn.cpp | 4 ++-- llvm/lib/Target/PowerPC/PPCFastISel.cpp | 8 ++++---- .../Target/WebAssembly/WebAssemblyRegColoring.cpp | 3 +-- llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp | 5 ++--- 10 files changed, 25 insertions(+), 27 deletions(-) diff --git a/llvm/lib/Target/ARM/ARMFrameLowering.cpp b/llvm/lib/Target/ARM/ARMFrameLowering.cpp index 831b6b0fc72231..e94b0f6e1a44fc 100644 --- a/llvm/lib/Target/ARM/ARMFrameLowering.cpp +++ b/llvm/lib/Target/ARM/ARMFrameLowering.cpp @@ -1673,8 +1673,8 @@ void ARMFrameLowering::emitPopInst(MachineBasicBlock &MBB, .addReg(ARM::SP) .add(predOps(ARMCC::AL)) .setMIFlags(MachineInstr::FrameDestroy); - for (unsigned i = 0, e = Regs.size(); i < e; ++i) - MIB.addReg(Regs[i], getDefRegState(true)); + for (unsigned Reg : Regs) + MIB.addReg(Reg, getDefRegState(true)); if (DeleteRet) { if (MI != MBB.end()) { MIB.copyImplicitOps(*MI); diff --git a/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp b/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp index e5e817f1ed9a29..b55b9a42e52cdf 100644 --- a/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp +++ b/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp @@ -2579,8 +2579,8 @@ ARMPreAllocLoadStoreOpt::RescheduleLoadStoreInstrs(MachineBasicBlock *MBB) { Bases.push_back(Base); return; } - for (unsigned i = 0, e = BI->second.size(); i != e; ++i) { - if (Offset == getMemoryOpOffset(*BI->second[i])) { + for (const MachineInstr *MI : BI->second) { + if (Offset == getMemoryOpOffset(*MI)) { StopHere = true; break; } diff --git a/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp b/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp index 99745941d57986..6926b02701771d 100644 --- a/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp +++ b/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp @@ -1056,8 +1056,8 @@ bool DeadCodeElimination::runOnNode(MachineDomTreeNode *N) { continue; B->erase(MI); - for (unsigned i = 0, n = Regs.size(); i != n; ++i) - MRI.markUsesInDebugValueAsUndef(Regs[i]); + for (unsigned Reg : Regs) + MRI.markUsesInDebugValueAsUndef(Reg); Changed = true; } diff --git a/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp b/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp index a4304b0531666a..8840c272057ab5 100644 --- a/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp +++ b/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp @@ -1040,8 +1040,8 @@ void HexagonGenInsert::pruneEmptyLists() { if (I->second.empty()) Prune.push_back(I); } - for (unsigned i = 0, n = Prune.size(); i < n; ++i) - IFMap.erase(Prune[i]); + for (const auto &It : Prune) + IFMap.erase(It); } void HexagonGenInsert::pruneCoveredSets(unsigned VR) { @@ -1470,8 +1470,8 @@ bool HexagonGenInsert::removeDeadCode(MachineDomTreeNode *N) { continue; B->erase(MI); - for (unsigned I = 0, N = Regs.size(); I != N; ++I) - MRI->markUsesInDebugValueAsUndef(Regs[I]); + for (unsigned Reg : Regs) + MRI->markUsesInDebugValueAsUndef(Reg); Changed = true; } @@ -1582,8 +1582,8 @@ bool HexagonGenInsert::runOnMachineFunction(MachineFunction &MF) { if (Idx >= Cutoff) Out.push_back(I); } - for (unsigned i = 0, n = Out.size(); i < n; ++i) - IFMap.erase(Out[i]); + for (const auto &It : Out) + IFMap.erase(It); } if (IFMap.empty()) return Changed; diff --git a/llvm/lib/Target/Mips/MipsFastISel.cpp b/llvm/lib/Target/Mips/MipsFastISel.cpp index ec12af66ff2d41..bd8ef43da625c3 100644 --- a/llvm/lib/Target/Mips/MipsFastISel.cpp +++ b/llvm/lib/Target/Mips/MipsFastISel.cpp @@ -1763,8 +1763,8 @@ bool MipsFastISel::selectRet(const Instruction *I) { RetRegs.push_back(VA.getLocReg()); } MachineInstrBuilder MIB = emitInst(Mips::RetRA); - for (unsigned i = 0, e = RetRegs.size(); i != e; ++i) - MIB.addReg(RetRegs[i], RegState::Implicit); + for (unsigned Reg : RetRegs) + MIB.addReg(Reg, RegState::Implicit); return true; } diff --git a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp index d6e20932a247e3..0b654abd2814c1 100644 --- a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp @@ -861,8 +861,8 @@ void NVPTXAsmPrinter::emitGlobals(const Module &M) { *static_cast(NTM.getSubtargetImpl()); // Print out module-level global variables in proper order - for (unsigned i = 0, e = Globals.size(); i != e; ++i) - printModuleLevelGV(Globals[i], OS2, /*processDemoted=*/false, STI); + for (const GlobalVariable *GV : Globals) + printModuleLevelGV(GV, OS2, /*processDemoted=*/false, STI); OS2 << '\n'; diff --git a/llvm/lib/Target/PowerPC/PPCEarlyReturn.cpp b/llvm/lib/Target/PowerPC/PPCEarlyReturn.cpp index ff3d36d39fb297..4c522e2c5be41d 100644 --- a/llvm/lib/Target/PowerPC/PPCEarlyReturn.cpp +++ b/llvm/lib/Target/PowerPC/PPCEarlyReturn.cpp @@ -149,8 +149,8 @@ namespace { Changed = true; } - for (unsigned i = 0, ie = PredToRemove.size(); i != ie; ++i) - PredToRemove[i]->removeSuccessor(&ReturnMBB, true); + for (MachineBasicBlock *MBB : PredToRemove) + MBB->removeSuccessor(&ReturnMBB, true); if (Changed && !ReturnMBB.hasAddressTaken()) { // We now might be able to merge this blr-only block into its diff --git a/llvm/lib/Target/PowerPC/PPCFastISel.cpp b/llvm/lib/Target/PowerPC/PPCFastISel.cpp index 0e04bb944c3bba..8d364bcb223940 100644 --- a/llvm/lib/Target/PowerPC/PPCFastISel.cpp +++ b/llvm/lib/Target/PowerPC/PPCFastISel.cpp @@ -1668,8 +1668,8 @@ bool PPCFastISel::fastLowerCall(CallLoweringInfo &CLI) { } // Add implicit physical register uses to the call. - for (unsigned II = 0, IE = RegArgs.size(); II != IE; ++II) - MIB.addReg(RegArgs[II], RegState::Implicit); + for (unsigned Reg : RegArgs) + MIB.addReg(Reg, RegState::Implicit); // Direct calls, in both the ELF V1 and V2 ABIs, need the TOC register live // into the call. @@ -1793,8 +1793,8 @@ bool PPCFastISel::SelectRet(const Instruction *I) { MachineInstrBuilder MIB = BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, MIMD, TII.get(PPC::BLR8)); - for (unsigned i = 0, e = RetRegs.size(); i != e; ++i) - MIB.addReg(RetRegs[i], RegState::Implicit); + for (unsigned Reg : RetRegs) + MIB.addReg(Reg, RegState::Implicit); return true; } diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyRegColoring.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyRegColoring.cpp index 8a74d77e369f6b..7dc5c099c1270f 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyRegColoring.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyRegColoring.cpp @@ -135,8 +135,7 @@ static void undefInvalidDbgValues( #ifndef NDEBUG DenseSet SeenRegs; #endif - for (size_t I = 0, E = Assignments.size(); I < E; ++I) { - const auto &CoalescedIntervals = Assignments[I]; + for (const auto &CoalescedIntervals : Assignments) { if (CoalescedIntervals.empty()) continue; for (LiveInterval *LI : CoalescedIntervals) { diff --git a/llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp b/llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp index 793e624eefa8a5..95962d1a0a240f 100644 --- a/llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp +++ b/llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp @@ -178,8 +178,7 @@ bool XCoreLowerThreadLocal::runOnModule(Module &M) { for (GlobalVariable &GV : M.globals()) if (GV.isThreadLocal()) ThreadLocalGlobals.push_back(&GV); - for (unsigned I = 0, E = ThreadLocalGlobals.size(); I != E; ++I) { - MadeChange |= lowerGlobal(ThreadLocalGlobals[I]); - } + for (GlobalVariable *GV : ThreadLocalGlobals) + MadeChange |= lowerGlobal(GV); return MadeChange; }