From 49a5c526f586e2a04b6e87f02112dd61b21ffefd Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 5 Aug 2024 15:35:10 -0500 Subject: [PATCH] Address comments --- libcxx/CMakeLists.txt | 2 +- libcxx/utils/libcxx/test/features.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt index 3699eca640772f..434ca34321bdb2 100644 --- a/libcxx/CMakeLists.txt +++ b/libcxx/CMakeLists.txt @@ -97,6 +97,7 @@ option(LIBCXX_ENABLE_UNICODE "Whether to include support for Unicode in the library. Disabling Unicode can be useful when porting to platforms that don't support UTF-8 encoding (e.g. embedded)." ON) +option(LIBCXX_HAS_TERMINAL_AVAILABLE "Build libc++ with terminal checking support" ON) option(LIBCXX_ENABLE_WIDE_CHARACTERS "Whether to include support for wide characters in the library. Disabling wide character support can be useful when porting to platforms that don't @@ -297,7 +298,6 @@ option(LIBCXX_HAS_WIN32_THREAD_API "Ignore auto-detection and force use of win32 option(LIBCXX_HAS_EXTERNAL_THREAD_API "Build libc++ with an externalized threading API. This option may only be set to ON when LIBCXX_ENABLE_THREADS=ON." OFF) -option(LIBCXX_HAS_TERMINAL_AVAILABLE "Build libc++ with terminal checking support" ON) if (LIBCXX_ENABLE_THREADS) set(LIBCXX_PSTL_BACKEND "std_thread" CACHE STRING "Which PSTL backend to use") diff --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py index 97cdb0349885d6..6857a28eb32995 100644 --- a/libcxx/utils/libcxx/test/features.py +++ b/libcxx/utils/libcxx/test/features.py @@ -378,6 +378,7 @@ def _mingwSupportsModules(cfg): "_LIBCPP_HAS_NO_FILESYSTEM": "no-filesystem", "_LIBCPP_HAS_NO_RANDOM_DEVICE": "no-random-device", "_LIBCPP_HAS_NO_LOCALIZATION": "no-localization", + "_LIBCPP_HAS_NO_TERMINAL": "no-terminal", "_LIBCPP_HAS_NO_WIDE_CHARACTERS": "no-wide-characters", "_LIBCPP_HAS_NO_TIME_ZONE_DATABASE": "no-tzdb", "_LIBCPP_HAS_NO_UNICODE": "libcpp-has-no-unicode",