From 3b7a7f4cc43f90e79292700959c55a62ab87fd9a Mon Sep 17 00:00:00 2001 From: Ilya Leoshkevich Date: Sat, 13 Jul 2024 10:31:03 +0200 Subject: [PATCH] [sanitizer] Add missing newlines to __sanitizer_set_report_path() error messages (#98626) "Can't open file:" and "Can't create directory:" are lacking a newline. --- compiler-rt/lib/sanitizer_common/sanitizer_file.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp index 7ef499ce07b133..96af270f9d8b50 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp +++ b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp @@ -69,7 +69,7 @@ void ReportFile::ReopenIfNecessary() { WriteToFile(kStderrFd, ErrorMsgPrefix, internal_strlen(ErrorMsgPrefix)); WriteToFile(kStderrFd, full_path, internal_strlen(full_path)); char errmsg[100]; - internal_snprintf(errmsg, sizeof(errmsg), " (reason: %d)", err); + internal_snprintf(errmsg, sizeof(errmsg), " (reason: %d)\n", err); WriteToFile(kStderrFd, errmsg, internal_strlen(errmsg)); Die(); } @@ -88,6 +88,8 @@ static void RecursiveCreateParentDirs(char *path) { const char *ErrorMsgPrefix = "ERROR: Can't create directory: "; WriteToFile(kStderrFd, ErrorMsgPrefix, internal_strlen(ErrorMsgPrefix)); WriteToFile(kStderrFd, path, internal_strlen(path)); + const char *ErrorMsgSuffix = "\n"; + WriteToFile(kStderrFd, ErrorMsgSuffix, internal_strlen(ErrorMsgSuffix)); Die(); } path[i] = save;